[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

[Amy Kwan via Phabricator via cfe-commits]

amyk added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7572
+  "Current bitcast for incompatible vector types (%0 and %1) are deprecated. "
+  "The default behaviour will change to what implied by the "
+  "-fno-lax-vector-conversions option">,
----------------



================
Comment at: clang/lib/Sema/SemaOverload.cpp:1664
          !ToType->hasAttr(attr::ArmMveStrictPolymorphism))) {
+      if (!InOverloadResolution &&
+          FromType->castAs<VectorType>()->getVectorKind() ==
----------------
Just wanted to check, but is this case covered in the comment above? If it is not, can we add a comment for it?


================
Comment at: clang/lib/Sema/SemaOverload.cpp:13027
   // end up here.
+  //
   return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc,
----------------
Unnecessary change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126540/new/

https://reviews.llvm.org/D126540