[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

Kiran Chandramohan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 08:04:45 PDT 2022


kiranchandramohan added a comment.

In D125788#3535199 <https://reviews.llvm.org/D125788#3535199>, @sscalpone wrote:

> My proposal is:
>
> If the compiler compiles it, it ought to run.
> If the compiler can't compile it, it ought to clearly say why.
>
> 1. All tests of legal Fortran that compile & link must also execute correctly (which excludes tests that expect to catch a problem at runtime)
> 2. For all tests with unsupported features, the compiler must issues an error message and the message references the source-location of the unsupported feature
>
> My preference is to use the NAG test suite.   It is not freely available.

I strongly suspect that you might be able to win over some of the folks by sharing the status/list of failures/list of issues to be fixed for getting the NAG test suite to pass. As I have mentioned before, at least the companies involved have access to the NAG testsuite. The community can probably help you achieve the outlined goals faster. It can also help focus our efforts.  Some of our engineers have now worked with f18/flang for some time. While some issues might require a fix by the experts, many can be fixed by others.

A separate issue we have is that it is not clear which branch is it that is being used for testing with NAG. Since many fixes have landed in llvm-project/flang, I assume that fir-dev is now out of date. While most of upstreaming is complete there is still a bit of things left to upstream, should not take much time though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788



More information about the cfe-commits mailing list