[PATCH] D126126: [analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 23 05:26:22 PDT 2022


steakhal abandoned this revision.
steakhal added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:90
-SVal SimpleSValBuilder::evalMinus(NonLoc val) {
-  switch (val.getSubKind()) {
-  case nonloc::ConcreteIntKind:
----------------
martong wrote:
> I'd rather keep the `switch` because in D125318 we are going to extend with `nonloc::SymbolValKind` so, soon it will no longer be  a standalone case.
Okay, let's postpone this until things get settled with the unary ops stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126126/new/

https://reviews.llvm.org/D126126



More information about the cfe-commits mailing list