[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 07:38:44 PDT 2022


xazax.hun added a comment.

In D121120#3496597 <https://reviews.llvm.org/D121120#3496597>, @ymandel wrote:

> Just realized we left this open. How about a disclaimer at the top of the doc (.rst) file noting the potential cost?  Anyone using clang-tidy should be explicitly configuring which checks to run, so that may be sufficient. If we want to allow users to enable/disable flow-sensitive checks across the board, though, it seems like we would need to add a new option to `ClangTidyOptions` (https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidyOptions.h#L50).

Sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121120/new/

https://reviews.llvm.org/D121120



More information about the cfe-commits mailing list