[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 11:58:37 PDT 2022


xazax.hun added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unchecked-optional-access.rst:29
+
+Checking if a value exists, then accessing the value
+----------------------------------------------------
----------------
ymandel wrote:
> xazax.hun wrote:
> > I wonder if it would be easier to read if we had two top level categories, one for safe and one for unsafe accesses instead of switching back and forth between examples.
> Sounds good, done. Let me know if that's what you had in mind.
Yup, this is exactly what I had in mind, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121120/new/

https://reviews.llvm.org/D121120



More information about the cfe-commits mailing list