[PATCH] D124983: [HLSL} add -fcgl option flag.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 08:45:01 PDT 2022


aaron.ballman added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6765
          "as_6_5, as_6_6, as_6_7">;
+def fcgl : DXCFlag<"fcgl">,
+  HelpText<"Generate high-level code only. Without any dxil related passes.">;
----------------
beanz wrote:
> aaron.ballman wrote:
> > Any particular reason for this name? Naively, I have no idea what this does or how it relates to code generation.
> I have no idea what this name is short for… code gen language?… likeness?… lobotomy?…
> 
> We have this flag in DXC, and it is a useful shorthand.
> 
> Don’t know if @python3kgae or @pow2clk know what the actual abbreviation is.
Can we pick a more descriptive name, or would that make portability too much of a challenge? Could we have a more descriptive name and then have `-fcgl` be an alias for it, or is that overkill because this is a rarely-used option?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124983/new/

https://reviews.llvm.org/D124983



More information about the cfe-commits mailing list