[PATCH] D122663: Mark identifier prefixes as substitutable

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 08:13:06 PDT 2022


hvdijk added a comment.

In D122663#3471866 <https://reviews.llvm.org/D122663#3471866>, @erichkeane wrote:

> This actually wouldn't be necessary in this case: cxxfilt is already 'right', this is just for humans to be able to see "we changed this from mangling as <obviously wrong> to <looks right>".

That's a good point. We do have tests in clang that use llvm-cxxfilt already (the PPC intrinsic tests) so there should be no problem with it as a dependency; I think once this is in I might submit that as a follow-up change for review unless someone else beats me to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122663/new/

https://reviews.llvm.org/D122663



More information about the cfe-commits mailing list