[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

Thu Apr 21 05:17:12 PDT 2022

zibi added inline comments.

================
Comment at: clang/test/Driver/linker-wrapper-image.c:8
+
+// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry
+// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry
----------------
jhuber6 wrote:
> jhuber6 wrote:
> > zibi wrote:
> > > On PowerPC I'm seeing the following error: pointing at `@` char:
> > > clang/test/Driver/linker-wrapper-image.c:10:12: error: OPENMP: expected string not found in input
> > > // OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry
> > > 
> > > Are you aware of this?
> > Do you have a link to a buildbot with the full error log? I'll try to test it locally by manually setting the triple.
> I tested this on a PPC64LE machine and couldn't reproduce, do you have any more information?
Yes, those test cases do pass on external bots. At the time of reporting I did not know this affects only the internal builds. We will handle this internally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124039/new/

https://reviews.llvm.org/D124039