[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 10:39:27 PDT 2022


cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaLambda.cpp:1378-1383
+  CompleteLambdaCallOperator(
+      Method, Intro.Range.getBegin(), ParamInfo.getTrailingRequiresClause(),
+      MethodTyInfo, ParamInfo.getDeclSpec().getConstexprSpecifier(), Params,
+      ExplicitResultType);
 
+  ContextRAII ManglingContext(*this, Class->getDeclContext());
----------------
aaron.ballman wrote:
> The previous logic was to enter a mangling context and then check params, but the new logic checks params outside of the mangling context. Is that intentional?
It has no impact one way or another, but we can't call `CompleteLambdaCallOperator` in the context of the class, so this is simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124012/new/

https://reviews.llvm.org/D124012



More information about the cfe-commits mailing list