[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 12:54:27 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D123065#3427382 <https://reviews.llvm.org/D123065#3427382>, @bernhardmgruber wrote:

> I did not base this revision on my latest main (422d05e792dbd6a97f5afd4cdd5e8aa677e97444 <https://reviews.llvm.org/rG422d05e792dbd6a97f5afd4cdd5e8aa677e97444>) since I could not run the python scripts with the changes introduced in 9e1f4f13984186984ba37513372c1b7e0c4ba4fd <https://reviews.llvm.org/rG9e1f4f13984186984ba37513372c1b7e0c4ba4fd>.

Can you try with https://reviews.llvm.org/D123074 applied, just to double-check my LG? :-)

The changes here LGTM otherwise (very minor nit with the help text wording, feel free to ignore if you disagree with the rewording), thank you for the fix!



================
Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:165
+                      action='append', default=[],
+                      help='Make clang-tidy load the specified plugin')
+
----------------



================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:277
+                      action='append', default=[],
+                      help='Make clang-tidy load the specified plugin')
   args = parser.parse_args()
----------------



Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123065/new/

https://reviews.llvm.org/D123065



More information about the cfe-commits mailing list