[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

Tom Honermann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 12:59:05 PDT 2022


tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.

Looks good to me! I left one final comment about a double period that was my fault.



================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1578
+  /// may not reference aliases. Redirection is only performed if 'Elem' is only
+  /// used by ifuncs in which case, 'Elem' is destroyed.. 'true' is returned If
+  /// redirection is successful, and 'false' is returned otherwise.
----------------
Double period; that was my badness that you dutifully copy pasted :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122608/new/

https://reviews.llvm.org/D122608



More information about the cfe-commits mailing list