[PATCH] D122104: [X86][regcall] Support passing / returning structures

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 09:04:40 PDT 2022


erichkeane added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:3992
     --FreeIntRegs;
+  else if (NeededSSE && MaxVectorWidth > 0)
+    FI.setMaxVectorWidth(MaxVectorWidth);
----------------
erichkeane wrote:
> This line here accesses NeededSSE while uninitialized.  Do you  need to initalize it to something on 3963?
Fixed: https://github.com/llvm/llvm-project/commit/2267549296dabfed31ce194bb124f7bdb91f74c5

Please confirm the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122104/new/

https://reviews.llvm.org/D122104



More information about the cfe-commits mailing list