[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3
+
+// REQUIRES: shell
+
----------------
saudi wrote:
> I was wondering whether it could be a concern that this test will be skipped on Windows systems, where `clang-cl` specific development would most likely occur.
> 
> However I'm pretty sure it's ok, since this test is pretty simple and small, has little chances to break during most development iterations, and we would run the tests under linux at some point anyway.
I agree it's not great, but we need to be able to create an executable here (to simulate `clang -print-resource-dir`). Since Windows doesn't have the concept of shebangs, I don't think there's a way to make this work. I remember also trying to achieve this by creating a `.py` script and relying on Windows' "run `.py` files with the Python interpreter" rule. Unfortunately, that doesn't kick in when we run the command from within Clang.

This page https://llvm.org/docs/GettingStartedVS.html#software says Git for Windows with bash tools is required for building LLVM, so I think it's reasonable to expect `REQUIRES: shell` will pass for a lot of Windows developers. Is that not the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121812/new/

https://reviews.llvm.org/D121812