[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 07:51:15 PDT 2022


dblaikie added inline comments.


================
Comment at: clang/utils/TableGen/MveEmitter.cpp:1197
+    const Type *Ty = nullptr;
+    if (auto *DI = dyn_cast<DagInit>(D->getArg(0))->getOperator())
+      if (auto *PTy = dyn_cast<PointerType>(getType(DI, Param)))
----------------
nikic wrote:
> Should be either `cast` or check for nullptr before dereferencing?
Not sure I follow the question - which variable are you pointing to that needs a null check before its use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122046/new/

https://reviews.llvm.org/D122046



More information about the cfe-commits mailing list