[PATCH] D121450: [clang-format] Handle attributes before case label.

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 12 00:14:09 PST 2022


curdeius added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:578
+        break;
+
       LLVM_FALLTHROUGH;
----------------
owenpan wrote:
> Can we remove this empty line?
Will do.


================
Comment at: clang/lib/Format/UnwrappedLineParser.h:125-126
   FormatToken *parseIfThenElse(IfStmtKind *IfKind, bool KeepBraces = false);
+  void handleAttributes();
+  bool handleCppAttributes();
   void parseTryCatch();
----------------
owenpan wrote:
> Can we move them 1 line up so that the order of the declarations here will be the same as that of the definitions in the .cpp file?
Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121450/new/

https://reviews.llvm.org/D121450



More information about the cfe-commits mailing list