[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

Tue Mar 8 21:42:06 PST 2022

tbaeder marked 3 inline comments as done.
tbaeder added a comment.

In D120244#3368216 <https://reviews.llvm.org/D120244#3368216>, @aaron.ballman wrote:

> Precommit CI is failing:
>
> Failed Tests (1):
>
>   Clang :: Headers/stdbool.c

Heh, I guess I need to make a habit of running the tests also //after// clang-format :/

================
Comment at: clang/test/Headers/stdbool.c:2
+// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c11 -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C11 %s
+// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c2x -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C2X %s
+
----------------
aaron.ballman wrote:
> If you're playing along at home, `stdbool.cpp` tests the C++ behavior, so we don't need an additional RUN line here for that.
> 
> However, I'd appreciate a RUN line that defines `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS` to demonstrate we don't emit the warning or the defines in that case.
I don't understand, both of the `RUN` lines are for C.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120244/new/

https://reviews.llvm.org/D120244