[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

Stanislav Gatev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 3 06:19:35 PST 2022


sgatev added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:26
+
+// Lattice for dataflow analysis that keeps track of a set of source locations.
+//
----------------
Doc comments start with `///`.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:55
+
+// Returns a string that represents the source locations of the lattice.
+std::string DebugString(const SourceLocationsLattice &Lattice,
----------------
Doc comments start with `///`.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56
+// Returns a string that represents the source locations of the lattice.
+std::string DebugString(const SourceLocationsLattice &Lattice,
+                        const ASTContext &Context);
----------------
Can you please add tests for this too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120890/new/

https://reviews.llvm.org/D120890



More information about the cfe-commits mailing list