[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

Dawid Jurczak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 25 03:15:37 PST 2022


yurai007 added a comment.

In D120334#3340639 <https://reviews.llvm.org/D120334#3340639>, @cor3ntin wrote:

> I like this approach. it seems a lot easier to maintain as people don't have to remember to use LangOptionsBase to not degrade performance

I like it either but we need to be careful about LangOptions lifetime as my previous comment shows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334



More information about the cfe-commits mailing list