[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

Sat Feb 19 05:51:07 PST 2022

ro added inline comments.

================
Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6
+/// Check sparc-sun-solaris2.11, 32bit
+// RUN: %clang %s -### 2>&1 \
+// RUN:     --target=sparc-sun-solaris2.11 \
----------------
MaskRay wrote:
> The first line is now shorter. You can move --target= above.
> 
> For me, the number of lines of a test counts and sometimes compacter RUN lines improve readability.
Depends: on long lines, crucial information can be harder to find.  I moved `--target=` up, but kept the distinguishing `-m64`/`-fsanitize=` in front.  Unfortunately, that causes some of the lines to be longer than 80 characters.

However, the `--gcc-toolchain=` and `--sysroot=` lines could easily be joined.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119829/new/

https://reviews.llvm.org/D119829