[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

Wed Feb 16 05:33:40 PST 2022

aaron.ballman added inline comments.

================
Comment at: clang/include/clang/AST/ASTContext.h:1117
   CanQualType BFloat16Ty;
-  CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3
+  CanQualType Float16Ty, Float16ComplexTy; // C11 extension ISO/IEC TS 18661-3
   CanQualType VoidPtrTy, NullPtrTy;
----------------
paulwalker-arm wrote:
> peterwaller-arm wrote:
> > Is this necessary?
> Is this necessary? I don't see any other `*ComplexTy` types in this file (i.e. there is no `DoubleComplexTy`).
This is the wrong way to handle this -- complex types are stored in the `ComplexTypes` folding set and are created through `ASTContext::getComplexType()`. So I don't think this change is necessary.

================
Comment at: clang/lib/AST/ASTContext.cpp:1330
   InitBuiltinType(Float16Ty,           BuiltinType::Float16);
+  InitBuiltinType(Float16ComplexTy,    BuiltinType::Float16);

----------------
paulwalker-arm wrote:
> peterwaller-arm wrote:
> > Is this necessary?
> As above.
Same here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119926/new/

https://reviews.llvm.org/D119926