[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

Mon Feb 14 13:30:29 PST 2022

arphaman added a comment.

In D118875#3296030 <https://reviews.llvm.org/D118875#3296030>, @bc-lee wrote:

> Hi, I built and tested clang using this patch and https://reviews.llvm.org/D118862. It works great.
> The current patch adds the -darwin-target-variant flag to all object files for MacOS targets in the compiler_rt's builtin library. However, users building compiler_rt may have compilers that don't support such flag, so it would be nice to have a CMake option to enable compiler flags like `COMPILER_RT_ENABLE_CATALYST`.

Good point. I will update the patch and add detection for the Mac catalyst support that detects if clang supports it with a flag .

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118875/new/

https://reviews.llvm.org/D118875