[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 00:38:15 PST 2022


MaskRay added a comment.

This needs some tests, otherwise there is a risk that others may break your changes when refactoring driver code.

The style I favor most is `test/Driver/linux-cross.cpp`. freebsd.c is not too bad. linux-ld.c is somewhat messy but can give you some idea what to test.
I'll add a note that zignore isn't tested and that is a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118021/new/

https://reviews.llvm.org/D118021



More information about the cfe-commits mailing list