[PATCH] D119207: [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels
Justin Lebar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 8 00:09:27 PST 2022
jlebar added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322
ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const {
- if (getContext().getLangOpts().HIP) {
+ if (getContext().getLangOpts().CUDAIsDevice) {
// Coerce pointer arguments with default address space to CrossWorkGroup
----------------
I am surprised by this change. Is the language mode HIP only when compiling for device? Or are you intentionally changing the behavior in HIP mode?
Same in SPIR.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119207/new/
https://reviews.llvm.org/D119207
More information about the cfe-commits
mailing list