[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

Digger Lin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 7 08:23:04 PST 2022


DiggerLin created this revision.
DiggerLin added reviewers: daltenty, hubert.reinterpretcast.
DiggerLin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

We currently only check driver Wl options and don't check for the plain
-b, -Xlinker or other options which get passed through to the linker
when we decide whether to run llvm-nm --export-symbols, so we may run it in
situations where we wouldn't if the user had used the equivalent
-Wl, prefixed options.

If we run the export list utility when the user has specified an export list,
we could export more symbols than they intended.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119147

Files:
  clang/include/clang/Driver/Job.h
  clang/lib/Driver/Job.cpp
  clang/lib/Driver/ToolChains/AIX.cpp
  clang/test/Driver/aix-ld.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119147.406473.patch
Type: text/x-patch
Size: 23215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220207/21e0794c/attachment-0001.bin>


More information about the cfe-commits mailing list