[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:101
   // and "x" will be treated as the same header when deleting #includes.
-  llvm::StringMap<llvm::SmallVector<Include, 1>> ExistingIncludes;
+  llvm::StringMap<std::list<Include>> ExistingIncludes;
 
----------------
May be worth a comment here that std::list is used for pointer stability, since it looks a little odd at first glance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118755/new/

https://reviews.llvm.org/D118755