[PATCH] D111100: enable plugins for clang-tidy

[Michał Górny via Phabricator via cfe-commits]

mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.

This breaks build of clang against system-installed LLVM:

  CMake Error at /usr/lib/llvm/14/lib64/cmake/llvm/AddLLVM.cmake:1821 (add_dependencies):
    The dependency target "LLVMHello" of target "check-all" does not exist.
  Call Stack (most recent call first):
    CMakeLists.txt:574 (add_lit_target)

`LLVMHello` isn't installed, so you can't rely on it being available. The customary way to resolve this kind of issue would be to check whether the target is present, and build it via `add_subdirectory()` against the respective LLVM directory (see how LLVMTestingSupport is handled in unittests). That said, you will also probably need to account for different build path (it will land in clang's shlibdir).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111100/new/

https://reviews.llvm.org/D111100