[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

[David Blaikie via Phabricator via cfe-commits]

dblaikie added inline comments.


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1895
+                                 Target.isPS4() || Target.isOSDarwin())) ||
+                     D->hasAttr<PackedAttr>();
 
----------------
dblaikie wrote:
> rsmith wrote:
> > Would it make sense to warn here if `Packed && !FieldPacked`, like GCC does?
> Probably? Happy to implement that in a follow-up.
Warning sent for review here: https://reviews.llvm.org/D118511


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117616/new/

https://reviews.llvm.org/D117616