[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

David Tenty via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 28 08:08:16 PST 2022


daltenty added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:5204
 
 /// Warn if a pointer or reference argument passed to a function points to an
 /// object that is less aligned than the parameter. This can happen when
----------------
This function definitely seems like the right place for this check. Maybe let's update the comment here to reflect we are checking more than the original alignment property this describes.



================
Comment at: clang/test/Sema/aix-attr-align.c:4
 // RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -verify -fsyntax-only %s
-// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -verify=off -Wno-aix-compat -fsyntax-only %s
-// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -verify=off -Wno-aix-compat -fsyntax-only %s
----------------
Why remove all the `-Wno-aix-compat` flag cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118350/new/

https://reviews.llvm.org/D118350



More information about the cfe-commits mailing list