[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D117744#3275226 <https://reviews.llvm.org/D117744#3275226>, @labath wrote:

> This (unsurprisingly) broke an lldb test for the gnu style compression. You didn't get the notification because the bot was already red at the time. I've already fixed the situation by converting the test to yaml, but I thought you may want to know what happened.

Thanks for aaa9f40e3fd2dd081e965d39f10649bcd8bf1d21 <https://reviews.llvm.org/rGaaa9f40e3fd2dd081e965d39f10649bcd8bf1d21> :) Sorry that I missed `-Wa,--compress-debug-sections=zlib-gnu` in the test.

To be accurate, the zlib-gnu style compression is still available with `llvm-mc -filetype=obj -compress-debug-sections=zlib-gnu` (that I haven't dropped but will do after a while).
It's just that the feature is not available in any user-facing tool.

And sound good to remove lldb reading support at some point.
I have found that Go's own linker generates `.zdebug` and notified them to fix it (https://go-review.googlesource.com/c/go/+/380755/)
If lldb debugability with older Go (once they have fixed the issue) is not so useful, yeah, drop the support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117744/new/

https://reviews.llvm.org/D117744