[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 7 15:20:21 PST 2022


sammccall added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1955
+  bool IsPrivateHeader;
+  SmallString<128> FrameworkName, IncludeSpelling;
+  if (BestPrefixIsFramework &&
----------------
sammccall wrote:
> nit: I don't think these strings need to be so big, framework includes are a fairly uncommon case probably?
nvm, not sure where I got that idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115183/new/

https://reviews.llvm.org/D115183



More information about the cfe-commits mailing list