[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

> applies just as well to the proposal of force-wrapping at >= 2 imports

Absolutely.. but it justifies that this option has got to the point that its no longer one thing or the other based on our personal subjective opinions... now we need to break down what we need and make this a better feature

otherwise we just flip-flop between different groups of users calling it a regression. The ideal would be that whatever options we add, the default would give us exactly as we have today, almost warts and all. but the options would allow us to give all the possibilities we think people might want, or leave us room to expand into those options (moving to an enum normally helps that)

i.e.

  JavaScriptWrapImports: Never (false)
  JavaScriptWrapImports: Multiple (true)  // meaning more than 1
  JavaScriptWrapImports: Always 

Therefore wouldn't the current behaviour for  ColumnLimit: 0 be JavaScriptWrapImports: Always?  (or Never if you want them all on one line)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116638/new/

https://reviews.llvm.org/D116638