[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 6 19:19:53 PST 2022


sammccall added a comment.

(I know you're on vacation, this isn't urgent, just wanted to send it so I didn't lose it to git obscurity!)



================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:400
       return false;
-    // Allow whitespace and "=" at end of comment.
-    SourcePrefix = SourcePrefix.rtrim().rtrim('=').rtrim();
+    // Ignore some punctuation and whitespace around comment.
+    // In particular this allows designators to match nicely.
----------------
This makes the existing comment suppression (for param names) a bit sloppier, but I have a hard time imagining a case where punctuation makes a difference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116786/new/

https://reviews.llvm.org/D116786



More information about the cfe-commits mailing list