[PATCH] D116059: [Clang][CFG] check children statements of asm goto

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 6 16:26:57 PST 2022


nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.


================
Comment at: clang/test/Analysis/uninit-asm-goto.cpp:84
+
+int test8() {
+    int x = 0; // expected-warning {{variable 'x' is used uninitialized whenever its declaration is reached}}
----------------
efriedma wrote:
> Looks like this patch fixes the false negative on test8; that's good.
> 
> It looks like there's a issue with the printed diagnostic on a bunch of these tests; we say the variable is used uninitialized "whenever its declaration is reached", which isn't right.  We can probably leave that for a followup; this is clearly an improvement.  But please file a bug.
https://github.com/llvm/llvm-project/issues/53060


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116059/new/

https://reviews.llvm.org/D116059



More information about the cfe-commits mailing list