[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 3 07:35:45 PST 2022


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!



================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:270
+    // We don't want this, so keep track of them to fix afterwards.
+    llvm::DenseSet<diag::kind> NeedsWerrorExclusion;
+    for (diag::kind ID : Members) {
----------------
why do we need a set here, rather than a flag?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116147/new/

https://reviews.llvm.org/D116147



More information about the cfe-commits mailing list