[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:10393
+      if (Elt.getKind() == APValue::Int) {
+        Elt.setInt(-Elt.getInt());
+      } else {
----------------
Can this be `Elt.getInt().negate()`?


================
Comment at: clang/lib/AST/ExprConstant.cpp:10397
+               "Vector can only be int or float type");
+        Elt.setFloat(-Elt.getFloat());
+      }
----------------
Can this be `Elt.getFloat().changeSign()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115670/new/

https://reviews.llvm.org/D115670