[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Thanks, LGTM!

I have a couple of nits about the test changes, but with those I think this is good to merged.



================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54
 
+void verifyIncomingMultiFile(std::string SourceExt, std::string HeaderExt,
+                             Annotations &CalleeH, Annotations &Caller1H,
----------------
nit: rather than passing `std::string` by value, let's use `llvm::StringRef`

(`const std::string&` would also be fine, but I think `llvm::StringRef` is more conventional in this codebase)


================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:125
+    @implementation MyClass {}
+      +(void)call^ee {
+    }
----------------
nit: the intendation here seems a bit inconsistent. Can we either indent everything between `@implementation` and `@end`, or alternatively un-indent just this line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114058/new/

https://reviews.llvm.org/D114058