[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 19 00:10:25 PST 2021


owenpan added a comment.

In D114142#3139756 <https://reviews.llvm.org/D114142#3139756>, @MyDeveloperDay wrote:

> I'm thinking that those cases are handled else where

I was aware of that, but I didn't see `* //` was handled and tested explicitly. IMO, using `tok::comment` and adding a test case would make it explicit at no extra cost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114142/new/

https://reviews.llvm.org/D114142



More information about the cfe-commits mailing list