[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 15 01:13:54 PST 2021


SjoerdMeijer added a comment.

This introduces another way of setting (optional) architecture extensions and having two ways to do the same is nearly always a bad thing, which is how one of my colleagues phrased it.

This was already a complex area and thus I don't think introducing another is going to really simplify things. This is the main problem of this proposal. Other things are:

- ideally we keep these flags consistent with GCC, but that seems to be a no-go.
- how do these new `-m` flags and `-march` interact?

More subjective: for most users this whole `-march` business is abstracted away in build systems, so they won't have to deal with this, that's why this isn't so much of an improvement.

If we want a better user experience set options, there are probably other things that are more important, like checking legal/illegal architecture combinations.

So, in summary, we prefer not to go ahead with this. And the precedent that was mentioned, `-mcrc`, should probably be deprecated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113779/new/

https://reviews.llvm.org/D113779



More information about the cfe-commits mailing list