[clang] 46a68c8 - Sema: const-qualify ParsedAttr::iterator::operator*()
    Duncan P. N. Exon Smith via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Fri Nov 12 11:53:03 PST 2021
    
    
  
Author: Duncan P. N. Exon Smith
Date: 2021-11-12T11:47:16-08:00
New Revision: 46a68c85bfc99f0bc651e5096a641d5d4051e99d
URL: https://github.com/llvm/llvm-project/commit/46a68c85bfc99f0bc651e5096a641d5d4051e99d
DIFF: https://github.com/llvm/llvm-project/commit/46a68c85bfc99f0bc651e5096a641d5d4051e99d.diff
LOG: Sema: const-qualify ParsedAttr::iterator::operator*()
`const`-qualify ParsedAttr::iterator::operator*(), clearing up confusion
about the two meanings of const for pointers/iterators. Helps unblock
removal of (non-const) iterator_facade_base::operator->().
Added: 
    
Modified: 
    clang/include/clang/Sema/ParsedAttr.h
Removed: 
    
################################################################################
diff  --git a/clang/include/clang/Sema/ParsedAttr.h b/clang/include/clang/Sema/ParsedAttr.h
index 52b2c0d963fce..ff2303c84bd21 100644
--- a/clang/include/clang/Sema/ParsedAttr.h
+++ b/clang/include/clang/Sema/ParsedAttr.h
@@ -894,7 +894,7 @@ class ParsedAttributesView {
                                                 ParsedAttr> {
     iterator() : iterator_adaptor_base(nullptr) {}
     iterator(VecTy::iterator I) : iterator_adaptor_base(I) {}
-    reference operator*() { return **I; }
+    reference operator*() const { return **I; }
     friend class ParsedAttributesView;
   };
   struct const_iterator
        
    
    
More information about the cfe-commits
mailing list