[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

Frederic Cambus via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 19 14:42:55 PDT 2021


fcambus added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:182
     DefineStd(Builder, "unix", Opts);
+    if (this->HasFloat128)
+      Builder.defineMacro("__FLOAT128__");
----------------
mgorny wrote:
> Maybe I'm missing something but do you actually need to state `this->` explicitly?
Seems like it is necessary, yes. Other targets (Haiku, Linux, OpenBSD, Solaris) use the same `if (this->HasFloat128)` check, and build fails if I remove the `this->` part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111760/new/

https://reviews.llvm.org/D111760



More information about the cfe-commits mailing list