[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

Haowei Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 7 17:53:10 PDT 2021


haowei added a comment.

I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done.



================
Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4
+//
+// It should also be exposed to non-fuchsia platforms. This is desireable when
+// using common Fuchsia headers for building host libraries that also depend on
----------------
haowei wrote:
> phosek wrote:
> > Would this also set the availability attribute? Can we test it? If not then this isn't particularly useful.
> Do you mean the macros? I can add one.
@phosek  I added unit test for macros. Could you confirm it is what you suggested in the previous comments? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108592/new/

https://reviews.llvm.org/D108592



More information about the cfe-commits mailing list