[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Mon Sep 13 10:18:36 PDT 2021

aaron.ballman edited reviewers, added: aaron.ballman; removed: rsmith.
aaron.ballman added a subscriber: lattner.
aaron.ballman added a comment.

In D109701#2997892 <https://reviews.llvm.org/D109701#2997892>, @lattner wrote:

> I'm not sure who the best person is to review this, but it isn't me anymore sadly.  Richard, can you recommend someone?

It's likely me -- I added the original SARIF implementation. It'll be a bit before I have the chance to give this a thorough review though, in case others who know SARIF would like to chime in.

Btw, is the intent for this functionality to replace what's in SarifDiagnostics.cpp (https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp) fairly immediately? Or are we going to carry both implementations? (Having put very little consideration into it, it seems like the static analysis output would be a good test of how well your changes work in practice as there are tools out there already consuming that output.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109701/new/

https://reviews.llvm.org/D109701