[PATCH] D106577: [clang] Define __STDC_ISO_10646__

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 6 20:46:14 PDT 2021


hubert.reinterpretcast added a comment.

In D106577#2983709 <https://reviews.llvm.org/D106577#2983709>, @ThePhD wrote:

> What it does mean is that Clang and every other compiler - so long as they pick a ISO10646-code point capable encoding for their `wchar_t` literals - can define this preprocessor macro unconditionally. My understanding is that on most systems where things have not been patched / tweaked, this applies since Clang vastly prefers UTF-32 in most of its setups.
>
> It is my strong recommendation this patch be accepted and made unconditional, both in anticipation of the upcoming standard and the widespread existing practice.

The paper does //not// update 6.10.8.2 to add "when expressed as a wchar_t character constant" to the wording for the macro which is the subject of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106577/new/

https://reviews.llvm.org/D106577



More information about the cfe-commits mailing list