[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

Ludovic Jozeau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 05:42:38 PDT 2021


FederAndInk added a comment.

Ok, well, the reason I proposed this patch in the first place was that I have been working on a `.clang-format` schema (https://json-schema.org/) :) and I spotted the inconsistency. I checked, and clang-format reports an error if we give a negative value to an option expecting an unsigned. In the schema I am able to specify a minimum and I think it's appropriate to give the information to the user that it expect a positive/unsigned integer, what do you think?

Also, interesting question, how do we want to handle plural, as the formulation 'List of Types'  introduces it. If we do it manually, it won't scale. We could include a dependency in python to something like inflect <https://pypi.org/project/inflect/>. I'll upload a new patch soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108765/new/

https://reviews.llvm.org/D108765



More information about the cfe-commits mailing list