[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

Andy Wingo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 20 05:04:43 PDT 2021


wingo added inline comments.


================
Comment at: clang/lib/CodeGen/Address.h:31
       : Pointer(pointer), Alignment(alignment) {
     assert((!alignment.isZero() || pointer == nullptr) &&
            "creating valid address with invalid alignment");
----------------
It would be nice to assert(isValid()) here but that's not how Address is used; you can pass in a nullptr as the first argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108458/new/

https://reviews.llvm.org/D108458



More information about the cfe-commits mailing list