[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 13 13:03:24 PDT 2021


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17
 #include "FormatToken.h"
-#include "clang/Basic/TokenKinds.h"
 #include "llvm/ADT/STLExtras.h"
----------------
owenpan wrote:
> HazardyKnusperkeks wrote:
> > Why is this not needed anymore?
> It was added in [[ https://reviews.llvm.org/D107950 | D107950 ]] but not needed even there.
I would put that in a different commit, it has nothing to do with what is changed here. And the revert is the example why I would put that in different commits. :)

But I will not stand in the way to land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107961/new/

https://reviews.llvm.org/D107961



More information about the cfe-commits mailing list