[PATCH] D108021: [dllexport] Instantiate default ctor default args

Peter Jiachen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 13 08:35:29 PDT 2021


peterjc123 added a comment.

In D108021#2943842 <https://reviews.llvm.org/D108021#2943842>, @rnk wrote:

> I think it looks good, but it needs a test.
>
> I worry that we might have the same bug for copy closures, but the fix will be different, since those are used in exception handling.

Thanks for your review. Since I'm pretty new to this repo, could you please tell me how to write a test here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108021/new/

https://reviews.llvm.org/D108021



More information about the cfe-commits mailing list