[PATCH] D107786: [AIX]: Fix option processing for -b

Ettore Tiotto via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 9 15:07:08 PDT 2021


etiotto created this revision.
etiotto added reviewers: ZarkoCA, hubert.reinterpretcast, Whitney, cebowleratibm.
etiotto added a project: LLVM.
etiotto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Code added by D106688 <https://reviews.llvm.org/D106688> is incorrect. It pass the option `-bxyz` to the system linker as `-b xyz xyz` (duplication of the string 'xyz' is incorrect).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107786

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp


Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -268,7 +268,7 @@
       A.render(Args, CmdArgs);
     }
     // Handle reserved library options.
-    if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
+    else if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
       TC.AddCXXStdlibLibArgs(Args, CmdArgs);
     else if (A.getOption().matches(options::OPT_Z_reserved_lib_cckext))
       TC.AddCCKextLibArgs(Args, CmdArgs);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107786.365295.patch
Type: text/x-patch
Size: 615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210809/3ab1e63c/attachment-0001.bin>


More information about the cfe-commits mailing list