[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Ok if you think that setting GCC version to higher values by default won't break anything, I think we should update this for all of clang instead. Apparently that was something done in the past already in https://github.com/llvm/llvm-project/commit/b5fe494a2cdd33a0b069939795043f538e9a492c. It is currently being set in https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L6127.

If we bumped the version number there for all of clang by default, clangd wouldn't be lying about the version and this will have a much wider visibility. That way we'll be sure that users won't see breakages specific to clangd and we'll also be able to get opinions from other stakeholders in clang that know about possible side effects of this bump. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107304/new/

https://reviews.llvm.org/D107304