[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

[Petr Hosek via Phabricator via cfe-commits]

phosek added inline comments.


================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:234
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS} -mllvm --hwasan-globals=0" CACHE STRING "")
+
----------------
I missed this earlier, but this isn't going to work since the variable isn't populated, you're going to need `${FUCHSIA_aarch64-unknown-fuchsia+hwasan_COMPILER_FLAGS}` here.


================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:234
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS} -mllvm --hwasan-globals=0" CACHE STRING "")
+
----------------
phosek wrote:
> I missed this earlier, but this isn't going to work since the variable isn't populated, you're going to need `${FUCHSIA_aarch64-unknown-fuchsia+hwasan_COMPILER_FLAGS}` here.
Could we set this in the backend when targeting Fuchsia and avoid the having to pass the flag manually?


================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:243
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
+  set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_CMAKE_CXX_FLAGS} -mllvm --hwasan-globals=0" CACHE STRING "")
+
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99364/new/

https://reviews.llvm.org/D99364